chore: cleanup

go-vela · Oct 29, 2024 · e239480 · e239480
1 parent 9410191
commit e239480
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 20 deletions.
diff --git a/compiler/registry/github/github.go b/compiler/registry/github/github.go
@@ -68,14 +68,6 @@ func (c *client) newOAuthTokenClient(ctx context.Context, token string) *github.
 
 	// create the OAuth client
 	tc := oauth2.NewClient(ctx, ts)
-	// if c.SkipVerify {
-	// 	tc.Transport.(*oauth2.Transport).Base = &http.Transport{
-	// 		Proxy: http.ProxyFromEnvironment,
-	// 		TLSClientConfig: &tls.Config{
-	// 			InsecureSkipVerify: true,
-	// 		},
-	// 	}
-	// }
 
 	// create the GitHub client from the OAuth client
 	github := github.NewClient(tc)

diff --git a/mock/server/repo.go b/mock/server/repo.go
@@ -80,7 +80,7 @@ const (
     "private": false,
     "trusted": true,
     "active": true,
-  	"install_id": 0
+    "install_id": 0
   },
   {
     "id": 2,
@@ -97,7 +97,7 @@ const (
     "private": false,
     "trusted": true,
     "active": true,
-  	"install_id": 0
+    "install_id": 0
   }
 ]`
 )

diff --git a/scm/github/app_client.go b/scm/github/app_client.go
@@ -27,14 +27,6 @@ func (c *client) newOAuthTokenClient(ctx context.Context, token string) *github.
 
 	// create the OAuth client
 	tc := oauth2.NewClient(ctx, ts)
-	// if c.SkipVerify {
-	// 	tc.Transport.(*oauth2.Transport).Base = &http.Transport{
-	// 		Proxy: http.ProxyFromEnvironment,
-	// 		TLSClientConfig: &tls.Config{
-	// 			InsecureSkipVerify: true,
-	// 		},
-	// 	}
-	// }
 
 	if c.Tracing.Config.EnableTracing {
 		tc.Transport = otelhttp.NewTransport(

diff --git a/scm/github/app_transport.go b/scm/github/app_transport.go
@@ -92,8 +92,8 @@ func (c *client) newAppsTransportFromPrivateKey(tr http.RoundTripper, appID int6
 // RoundTrip implements http.RoundTripper interface.
 func (t *AppsTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 	// GitHub rejects expiry and issue timestamps that are not an integer,
-	// while the jwt-go library serializes to fractional timestamps.
-	// Truncate them before passing to jwt-go.
+	// while the jwt-go library serializes to fractional timestamps
+	// then truncate them before passing to jwt-go.
 	iss := time.Now().Add(-30 * time.Second).Truncate(time.Second)
 	exp := iss.Add(2 * time.Minute)
 	claims := &jwt.RegisteredClaims{