-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error early if apply test vectors returns INVALID payload #20
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,14 +24,28 @@ until curl -X POST -H "Content-Type: application/json" \ | |
sleep 2 | ||
done | ||
|
||
BLOCK_COUNTER=0 | ||
echo "Nethermind is available" | ||
|
||
declare -i BLOCK_COUNTER=0 | ||
|
||
function make_block() { | ||
((BLOCK_COUNTER++)) | ||
# increment block counter | ||
BLOCK_COUNTER=$((BLOCK_COUNTER + 1)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the motivation to change this syntax? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. difference in how this syntax is handled between sh and bash. earlier was getting an error where docker image was exiting as soon as the make_block function got called, this commit fixed it just verified it again with everything same, just the syntax reverted (https://github.com/debjit-bw/reth_gnosis/actions/runs/11368078320/job/31622284450) |
||
|
||
echo "Making block $BLOCK_COUNTER" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This appears to be a double log between this line and 163 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed from line 163 |
||
|
||
HEAD_BLOCK=$(curl -X POST -H "Content-Type: application/json" \ | ||
--data '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["latest", false],"id":1}' \ | ||
http://localhost:8545) | ||
--data "{ | ||
\"jsonrpc\":\"2.0\", | ||
\"method\":\"eth_getBlockByNumber\", | ||
\"params\":[ | ||
\"latest\", | ||
false | ||
], | ||
\"id\":1 | ||
}" \ | ||
http://localhost:8545 \ | ||
) | ||
|
||
# --raw-output remove the double quotes | ||
HEAD_BLOCK_HASH=$(echo $HEAD_BLOCK | jq --raw-output '.result.hash') | ||
|
@@ -146,6 +160,7 @@ function make_block() { | |
N=5 | ||
|
||
for ((i = 1; i <= N; i++)); do | ||
echo "Making block $i" | ||
make_block | ||
done | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script maybe called for various clients, it's not nethermind only. You can say "EL is available"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done