Error early if apply test vectors returns INVALID payload #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Oct 16, 2024
scripts/generate_test_vectors.sh
Outdated
| @@ -24,14 +24,28 @@ until curl -X POST -H "Content-Type: application/json" \ | |||
| sleep 2 | |||
| done | |||
|
|
|||
| BLOCK_COUNTER=0 | |||
| echo "Nethermind is available" | |||
There was a problem hiding this comment.
This script maybe called for various clients, it's not nethermind only. You can say "EL is available"
| # increment block counter | ||
| BLOCK_COUNTER=$((BLOCK_COUNTER + 1)) | ||
|
|
||
| echo "Making block $BLOCK_COUNTER" |
There was a problem hiding this comment.
This appears to be a double log between this line and 163
|
|
||
| function make_block() { | ||
| ((BLOCK_COUNTER++)) | ||
| # increment block counter | ||
| BLOCK_COUNTER=$((BLOCK_COUNTER + 1)) |
There was a problem hiding this comment.
What's the motivation to change this syntax?
There was a problem hiding this comment.
difference in how this syntax is handled between sh and bash. earlier was getting an error where docker image was exiting as soon as the make_block function got called, this commit fixed it
just verified it again with everything same, just the syntax reverted (https://github.com/debjit-bw/reth_gnosis/actions/runs/11368078320/job/31622284450)
dapplion
changed the title
dapplion
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.