-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure for visual tests and first test(s) #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
visual-testing
branch
4 times, most recently
from
June 22, 2023 13:41
8028e87
to
170a9a8
Compare
astrofrog
force-pushed
the
visual-testing
branch
from
June 23, 2023 10:09
dd8dc5e
to
4aa27cc
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 89.58% 89.02% -0.57%
==========================================
Files 86 88 +2
Lines 4697 4757 +60
==========================================
+ Hits 4208 4235 +27
- Misses 489 522 +33
☔ View full report in Codecov by Sentry. |
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds infrastructure to do visual tests using Solara
I've also made use of pytest-mpl which gives the following benefits:
Note that we use CircleCI as in astropy because it allows the gallery to be hosted/rendered directly.
At the moment this requires a small hack which is to show the generated image in a Matplotlib figure but hopefully we can simplify things as mentioned in matplotlib/pytest-mpl#201
For now I also need to use a fork of Solara with widgetti/solara#167
Gallery preview: https://output.circle-artifacts.com/output/job/6d90ef24-a6a1-49e4-a7d0-fc5ac19e4b36/artifacts/0/results/fig_comparison.html