Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual testing #37

Open
Carifio24 opened this issue Jun 23, 2023 · 2 comments
Open

Visual testing #37

Carifio24 opened this issue Jun 23, 2023 · 2 comments
Labels
CI enhancement New feature or request

Comments

@Carifio24
Copy link
Member

This is a reminder to myself that we should set up some image-based testing of our outputs as part of the testing suite. Testing that the Plotly traces have the right properties goes a long way, but we should have some way to check that the final product looks correct.

Plotly supports static image export using Kaleido. We could use this to generate static output (e.g. a PNG, rather than interactive HTML) and compare to reference images. The HTML pages also support the ability to save a PNG - we should check whether this just calls the Kaleido static export, or is something different (and if the latter, see if we can activate that in a test).
@Carifio24 Carifio24 added enhancement New feature or request CI labels Jun 23, 2023
@astrofrog
Copy link
Member

As I did for glue-jupyter in glue-viz/glue-jupyter#360 we should make use of pytest-mpl to help with the testing, it can be used for non matplotlib output. Happy to give a demo at some point!

@Carifio24
Copy link
Member Author

Seeing that PR is actually what got me thinking about this! And yes, a demo would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astrofrog @Carifio24