Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completer to ensure rStart is passed after pty init #458

Conversation

Lutra-Fs
Copy link
Collaborator

@Lutra-Fs Lutra-Fs commented Sep 23, 2024

Pull Request Details

What issue does this PR address

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

  • Screenshots included in linked issue
  • Changes adhere to the style and coding guideline
  • No confidential information
  • No duplicated content
  • No lint check errors related to your changes (make prep or flutter analyze lib)
  • Pre-exisiting lint errors noted: [HERE]
  • Integration test make qtest.tmp screenshot included in issue
  • Tested on device:
    • Linux
    • MacOS
    • Windows
  • Added two reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the branch
  • Resolve any conflicts
  • Add one line summary into CHANGELOG.md
  • Bump appropriate version number in pubspec.yaml
  • Push to git repository and review
  • Merge PR into dev (gjwgit)

@Lutra-Fs Lutra-Fs requested review from gjwgit and zheyxu September 23, 2024 06:36
@Lutra-Fs Lutra-Fs linked an issue Sep 23, 2024 that may be closed by this pull request
@Lutra-Fs
Copy link
Collaborator Author

I hope that the code will not affect other platforms. Please do extra testing if okay.

@gjwgit gjwgit merged commit 1f3f27d into dev Sep 23, 2024
1 check passed
@gjwgit gjwgit deleted the lutra/264-windows-on-startup-from-the-zip-distrubtion-mainr-is-not-run branch September 23, 2024 06:53
@gjwgit gjwgit restored the lutra/264-windows-on-startup-from-the-zip-distrubtion-mainr-is-not-run branch September 23, 2024 21:56
@gjwgit
Copy link
Owner

gjwgit commented Sep 23, 2024

This update did not seem to fix the problem for me on my Windows test machine. Reverting the PR

@Lutra-Fs
Copy link
Collaborator Author

This update did not seem to fix the problem for me on my Windows test machine. Reverting the PR

What do you observed? Is that the restart passed to the PTY before the PTY initialized? If possible pls debug print the pty input and attached in the issue comment. Or are you on release build?

@Lutra-Fs
Copy link
Collaborator Author

Lutra-Fs commented Sep 24, 2024

I’m currently at the university and was wondering if we could squeeze in a quick meeting around 2:30 p.m. to go over the issue on your Windows env. No worries if that doesn’t work for you though! @gjwgit

@Lutra-Fs
Copy link
Collaborator Author

Have recorded a video. But due to limited bandwidth in uni I am unable to upload it now

@gjwgit
Copy link
Owner

gjwgit commented Sep 25, 2024

On startup I see the R initial and waiting for code but no code.

@Lutra-Fs Lutra-Fs deleted the lutra/264-windows-on-startup-from-the-zip-distrubtion-mainr-is-not-run branch October 5, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WINDOWS] On startup from the zip distrubtion main.R is not run
2 participants