-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WINDOWS] On startup from the zip distrubtion main.R is not run #264
Comments
Note that I can paste the contents of main.R into the CONSOLE to have it run and then rattle will operate for that session as expected. Perhaps it just needs |
Unfortunately this fix causes the following error for Linux:
Reverting for now. |
See TerminalStudio/flutter_pty#16. not test for linux so sorry for the issue introduced. I could create a fork with those fix and then we depend on that repo if you agree. |
Let's give it a go. |
Does this solve the issue for you @Lutra-Fs? I still do not have main.R being pushed into the Terminal on startup in Windows. |
To investigate
|
I will stick with the main.R inside dataset_prep.R for now - there is a small delay after loading the dataset before the pages are populated but might be okay. |
I didn't have that version in my pc so far. Will checkout the commit and see what happened here. |
Just have a quick check and I could confirm that in my build main.R works fine even the loading is in start stage. |
We need to fix the version number problem on Windows so I can see the version in the screenshots - #273 - perhaps you could debug that. Thanks. Can you share the screenshot of the Console tab - that is where the code is executed. It is simply displayed in the Script tab so there is no indication there that it has run. On Linux and MacOS I see this: |
Just have a deeper test and you're right. The pty received the start.R first, then the R console is ready to go, so there should be some issue between flutter-pty ConPty and R |
Thanks. Yes I suspect the async/sync needs work. In Linux I see the contents of main.R in the console before the R process starts, yet it gets executed anyhow. Same for MacOS I think. Seems like on Windows it does not end up getting executed or gets pushed to the Console before the console is ready. The process needs to be corrected to work under these scenarios. |
link to #298 |
This update did not seem to fix the problem for me on my Windows test machine. Plus running the test suite caused other tests to now fail. I have reverted the change. |
Sry for the delayed reply, the video is available at https://filesender.aarnet.edu.au/?s=download&token=d1a5d60a-cf57-41bc-b075-82b20b0f442b and will expire at 26/10/2024 |
Description
For the zip distribution of the rattlng package for Windows, when running the rattle.exe on Windows, after R starts up in the CONSOLE it does not run the main.R script. On Linux and MacOS the main.R script is run on startup.
This task is to investigate why main.R is not run on starting up rattle.exe on Windows.
The text was updated successfully, but these errors were encountered: