Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vintage-migration-changes #354
vintage-migration-changes #354
Changes from 27 commits
b2d246b
5ed7fc7
6673f62
7cb571b
6a1b9c9
1192c25
e44e7f2
0c80114
09eb343
2b98865
e7cee29
fdb217d
ef54c8d
05e695e
9fdaf77
0b62afa
fa4211f
df16bb0
c095c7a
fd5663f
5d8e86f
d52bbbc
9e1ce03
9c34334
d1556b5
cd87402
422c720
955911d
f1b2b30
c062d14
da86fa3
f2a64ef
98ab11b
f4696c2
ff35a60
c9c23e8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vintage listen on 443 and in the migration step we need to also set this to port 443, could be removed later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly for adding migration script for etcd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to support different etcd configurations? I was thinking if we need this value at all. Couldn't we just use whatever flags we need in
clusterConfiguration.etcd.local.extraArgs
and avoid making it configurable?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, because this extra arguments are only needed for the migration, so it cannot be set globally for all clusters, I need an option to turn specify them on demand fro the migration
anything under
.internal
should not be used by customers and anything undermigration
should be possible to remove after migration