vintage-migration-changes #354
Conversation
|
@calvix: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1 similar comment
|
@calvix: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…ster-aws into vintage-migration-changes
…ster-aws into vintage-migration-changes
…ster-aws into vintage-migration-changes
| "type": "integer", | ||
| "title": "Kubernetes API bind port", | ||
| "description": "Kubernetes API bind port used for kube api pod", | ||
| "default": 6443 |
There was a problem hiding this comment.
vintage listen on 443 and in the migration step we need to also set this to port 443, could be removed later
| "description": "Kubernetes API bind port used for kube api pod", | ||
| "default": 6443 | ||
| }, | ||
| "controlPlaneExtraFiles": { |
There was a problem hiding this comment.
mostly for adding migration script for etcd
|
the example how the new values are filled can be found here capi_app |
| "title": "command" | ||
| } | ||
| }, | ||
| "etcdExtraArgs": { |
There was a problem hiding this comment.
Do we need to support different etcd configurations? I was thinking if we need this value at all. Couldn't we just use whatever flags we need in clusterConfiguration.etcd.local.extraArgs and avoid making it configurable?
There was a problem hiding this comment.
no, because this extra arguments are only needed for the migration, so it cannot be set globally for all clusters, I need an option to turn specify them on demand fro the migration
anything under .internal should not be used by customers and anything under migration should be possible to remove after migration
Co-authored-by: Jose Armesto <[email protected]>
…ster-aws into vintage-migration-changes
|
once i get LGTM i will remove the custom user and merge but until then i need the user for testing purposes |
(helm/cluster-aws/ci/test-wc-minimal-values.yaml) rendered manifest diff/spec/kubeadmConfigSpec/initConfiguration/localAPIEndpoint/bindPort (KubeadmControlPlane/org-giantswarm/test-wc-minimal)
± value change
- 0
+ 6443
/spec/kubeadmConfigSpec/joinConfiguration (KubeadmControlPlane/org-giantswarm/test-wc-minimal)
+ one map entry added:
controlPlane:
localAPIEndpoint:
bindPort: 6443
|
Co-authored-by: Jose Armesto <[email protected]>
additional field necessary for migration from the vintage cluster
ref issue: https://github.com/giantswarm/giantswarm/issues/27910
the values are filled like this
https://github.com/giantswarm/capi-migration-cli/blob/main/pkg/migrator/capi_app.go#L79-L148