-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1-component ({s,u}{int,norm}{8,16}
, float16
) and unorm8x4-bgra
vertex formats
#6632
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I have a big change coming in that conflicts with this, I'm going to rebase so each commit can land separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait, hold on, metal is a lot more complicated unfortunately, as we don't use normal vertex formats, we manually transform to using vertex pulling.
First step is that I would add tests for all these new formats in https://github.com/gfx-rs/wgpu/blob/e23146aa3e8f5de0820cec108a9c1aa967454a3b/tests/tests/vertex_formats/mod.rs. This can probably join one of the other sets of tests.
Second step is to add support for these formats in naga -
wgpu/naga/src/back/msl/writer.rs
Line 4002 in 314e196
fn write_unpacking_function( |
I would appreciate the webgpu update as a separate PR, as this has a bit of work left still.
4f77000
to
faac144
Compare
47b610c
to
43c432b
Compare
7fdb5dc
to
d788e62
Compare
This should now be good to go @cwfitzgerald @ErichDonGubler |
Connections
Closes #6614
Description
When adding the translations from
wgpu::VertexFormat
to the various backends, I did my best to choose the appropriate formats, but I'm not too familiar with DX12 or Metal, so please, take some extra time to verify those.Testing
N/A
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.