Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check MACH_PORT_VALID on return from pthread_mach_thread_np #3520

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

fix: guard against null thread handle for profiler sampling thread (#…

6fac4d6
Select commit
Loading
Failed to load commit list.
Open

Check MACH_PORT_VALID on return from pthread_mach_thread_np #3520

fix: guard against null thread handle for profiler sampling thread (#…
6fac4d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 20, 2024 in 1s

91.165% (+1.923%) compared to 1734d1b

View this Pull Request on Codecov

91.165% (+1.923%) compared to 1734d1b

Details

Codecov Report

Attention: Patch coverage is 81.13208% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.165%. Comparing base (1734d1b) to head (6fac4d6).
Report is 343 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3520       +/-   ##
=============================================
+ Coverage   89.241%   91.165%   +1.923%     
=============================================
  Files          529       609       +80     
  Lines        57780     47846     -9934     
  Branches     20687         0    -20687     
=============================================
- Hits         51564     43619     -7945     
+ Misses        5300      4227     -1073     
+ Partials       916         0      -916     
Files Coverage Δ
Sources/Sentry/PrivateSentrySDKOnly.mm 90.714% <100.000%> (+3.558%) ⬆️
Sources/Sentry/SentryThreadHandle.cpp 62.727% <100.000%> (-6.504%) ⬇️
Sources/Sentry/SentryTransactionContext.mm 100.000% <100.000%> (ø)
...yCrash/Recording/Monitors/SentryCrashMonitorType.c 0.000% <ø> (ø)
...entryCrash/Recording/Tools/SentryCrashSignalInfo.c 100.000% <ø> (ø)
...sts/SentryProfilerTests/SentryThreadHandleTests.mm 95.789% <100.000%> (+2.932%) ⬆️
Tests/SentryTests/SentryCrash/CrashReport.swift 100.000% <100.000%> (+6.666%) ⬆️
Tests/SentryTests/SentryInterfacesTests.m 100.000% <100.000%> (ø)
...rding/Monitors/SentryCrashMonitor_CPPException.cpp 20.408% <0.000%> (-10.223%) ⬇️
Tests/SentryProfilerTests/SentryBacktraceTests.mm 95.744% <88.888%> (+0.939%) ⬆️
... and 2 more

... and 607 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1734d1b...6fac4d6. Read the comment docs.