Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check MACH_PORT_VALID on return from pthread_mach_thread_np #3520

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

fix: guard against null thread handle for profiler sampling thread (#…

6fac4d6
Select commit
Loading
Failed to load commit list.
Open

Check MACH_PORT_VALID on return from pthread_mach_thread_np #3520

fix: guard against null thread handle for profiler sampling thread (#…
6fac4d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jun 20, 2024 in 1s

81.132% of diff hit (target 89.241%)

View this Pull Request on Codecov

81.132% of diff hit (target 89.241%)

Annotations

Check warning on line 120 in Sources/Sentry/SentryBacktrace.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Sentry/SentryBacktrace.cpp#L118-L120

Added lines #L118 - L120 were not covered by tests

Check warning on line 73 in Sources/Sentry/SentrySamplingProfiler.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Sentry/SentrySamplingProfiler.cpp#L70-L73

Added lines #L70 - L73 were not covered by tests

Check warning on line 138 in Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp#L138

Added line #L138 was not covered by tests

Check warning on line 262 in Tests/SentryProfilerTests/SentryBacktraceTests.mm

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryProfilerTests/SentryBacktraceTests.mm#L261-L262

Added lines #L261 - L262 were not covered by tests