Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: measure cpu energy usage estimates #3217

Merged

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Aug 10, 2023

📜 Description

Extracted from #3187 for release to production.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@armcknight armcknight changed the title test: add features to iOS-Swift to help test profiling feat: measure cpu energy usage estimates Aug 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f2e517e

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #3217 (0c84886) into armcknight/test/ios-swift-additions (2543034) will increase coverage by 0.020%.
The diff coverage is 78.048%.

Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##           armcknight/test/ios-swift-additions     #3217       +/-   ##
=========================================================================
+ Coverage                               89.156%   89.176%   +0.020%     
=========================================================================
  Files                                      502       502               
  Lines                                    54076     54112       +36     
  Branches                                 19411     19419        +8     
=========================================================================
+ Hits                                     48212     48255       +43     
- Misses                                    4899      4998       +99     
+ Partials                                   965       859      -106     
Files Changed Coverage Δ
Sources/Sentry/SentrySystemWrapper.mm 66.666% <57.142%> (-2.899%) ⬇️
Sources/Sentry/SentryMetricProfiler.mm 93.835% <88.888%> (-1.123%) ⬇️

... and 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2543034...0c84886. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.45 ms 1251.29 ms 21.84 ms
Size 22.84 KiB 403.92 KiB 381.07 KiB

Baseline results on branch: armcknight/test/ios-swift-additions

Startup times

Revision Plain With Sentry Diff
fbf1d89 1210.94 ms 1235.38 ms 24.44 ms

App size

Revision Plain With Sentry Diff
fbf1d89 22.84 KiB 403.14 KiB 380.29 KiB

Previous results on branch: armcknight/feat/energy-metrics

Startup times

Revision Plain With Sentry Diff
c721236 1227.88 ms 1245.36 ms 17.48 ms

App size

Revision Plain With Sentry Diff
c721236 22.84 KiB 403.92 KiB 381.07 KiB

@armcknight armcknight force-pushed the armcknight/test/ios-swift-additions branch from a5b8747 to da8cbee Compare August 11, 2023 21:25
@armcknight armcknight force-pushed the armcknight/feat/energy-metrics branch from 8a6b947 to d7ebd02 Compare August 11, 2023 21:43
@armcknight armcknight marked this pull request as ready for review August 11, 2023 23:24
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sources/Sentry/SentrySystemWrapper.mm Show resolved Hide resolved
@armcknight armcknight merged commit 4beeeff into armcknight/test/ios-swift-additions Aug 16, 2023
4 checks passed
@armcknight armcknight deleted the armcknight/feat/energy-metrics branch August 16, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants