Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report energy usage in nanojoules #3262

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Aug 30, 2023

Copypasta in #3217 led to reporting the wrong units for energy profiling metrics.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #3262 (106c741) into main (df2986b) will increase coverage by 0.062%.
The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3262       +/-   ##
=============================================
+ Coverage   89.173%   89.235%   +0.062%     
=============================================
  Files          502       502               
  Lines        54209     54216        +7     
  Branches     19463     19467        +4     
=============================================
+ Hits         48340     48380       +40     
- Misses        4898      4982       +84     
+ Partials       971       854      -117     
Files Changed Coverage
Sources/Sentry/SentryMetricProfiler.mm 100.000%
...SentryProfilerTests/SentryProfilerSwiftTests.swift 100.000%

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2986b...106c741. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.65 ms 1257.88 ms 24.23 ms
Size 22.85 KiB 406.97 KiB 384.12 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c319795 1205.12 ms 1231.20 ms 26.08 ms
d40512b 1231.12 ms 1244.54 ms 13.42 ms
69d8759 1229.88 ms 1240.45 ms 10.57 ms
879fb28 1243.18 ms 1255.98 ms 12.80 ms
7f14650 1249.73 ms 1269.88 ms 20.14 ms
c0b4b71 1246.98 ms 1256.77 ms 9.79 ms
869ab7e 1230.36 ms 1255.49 ms 25.13 ms
eed479f 1198.93 ms 1228.12 ms 29.19 ms
84fb4d9 1212.45 ms 1223.39 ms 10.94 ms
9e6665f 1237.58 ms 1253.84 ms 16.26 ms

App size

Revision Plain With Sentry Diff
c319795 20.76 KiB 431.99 KiB 411.22 KiB
d40512b 20.76 KiB 427.77 KiB 407.00 KiB
69d8759 20.76 KiB 393.05 KiB 372.29 KiB
879fb28 22.84 KiB 402.88 KiB 380.03 KiB
7f14650 22.84 KiB 402.63 KiB 379.79 KiB
c0b4b71 20.76 KiB 430.98 KiB 410.22 KiB
869ab7e 20.76 KiB 432.88 KiB 412.11 KiB
eed479f 20.76 KiB 433.18 KiB 412.42 KiB
84fb4d9 22.84 KiB 402.56 KiB 379.72 KiB
9e6665f 22.84 KiB 403.52 KiB 380.67 KiB

Previous results on branch: armcknight/fix/energy-measurement-units

Startup times

Revision Plain With Sentry Diff
8d9f9d2 1253.80 ms 1277.04 ms 23.24 ms

App size

Revision Plain With Sentry Diff
8d9f9d2 22.85 KiB 406.94 KiB 384.09 KiB

@armcknight armcknight merged commit 7bb0873 into main Aug 31, 2023
66 checks passed
@armcknight armcknight deleted the armcknight/fix/energy-measurement-units branch August 31, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants