Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Customer): remove all CustomerDetails occurences #890

Merged
merged 7 commits into from
Mar 13, 2023

Conversation

ansmonjol
Copy link
Collaborator

@ansmonjol ansmonjol commented Mar 8, 2023

Context

This is the last item of removing the types Details task in app

This one is a bit tricky as it was used a lot on FE side and had different logic for the same attributes depending on the BE type

I tested the app with those changes and I had to add a refetchQuery when adding a subscription. This should be fixed in later data and fragment refactor on this part.

This is a good step forward for cache and fragment improvement for this part of the app

Description

This PR removes all CustomerDetails occurrences in the app to stick with the Customer one

@ansmonjol ansmonjol self-assigned this Mar 8, 2023
@ansmonjol ansmonjol added the 🥷 chore This doesn't seem right label Mar 8, 2023
@cypress
Copy link

cypress bot commented Mar 8, 2023

Passing run #1475 ↗︎

0 28 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7bc3b69 into 96e14bb...
Project: Lago Front End Commit: 32fa2e1d5d ℹ️
Status: Passed Duration: 03:06 💡
Started: Mar 13, 2023 3:53 PM Ended: Mar 13, 2023 3:56 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ansmonjol ansmonjol force-pushed the customer-single-object branch 5 times, most recently from bcd90ce to 562ef6d Compare March 10, 2023 09:04
@ansmonjol ansmonjol force-pushed the customer-single-object branch from 235aaf0 to 7bc3b69 Compare March 10, 2023 11:12
@ansmonjol ansmonjol enabled auto-merge (rebase) March 13, 2023 16:00
@ansmonjol ansmonjol disabled auto-merge March 13, 2023 16:01
@ansmonjol ansmonjol merged commit bd87a4e into main Mar 13, 2023
@ansmonjol ansmonjol deleted the customer-single-object branch March 13, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥷 chore This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant