misc(Customer): merge single object and object types #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdenquin
reviewed
Mar 8, 2023
jdenquin
reviewed
Mar 8, 2023
jdenquin
reviewed
Mar 8, 2023
ansmonjol
force-pushed
the
customer-single-object
branch
from
fd865ea to
723896b
Compare
jdenquin
reviewed
Mar 8, 2023
rsempe
approved these changes
Mar 8, 2023
ansmonjol
force-pushed
the
customer-single-object
branch
2 times, most recently
from
1366c0a to
5e27c34
Compare
ansmonjol
force-pushed
the
customer-single-object
branch
from
5e27c34 to
62b0e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is the last task removing single_object types over the app.
This one is a bit tricky as it was really used on FE side and had different logic for the same attributes depending on the type.
Overall:
invoices,applied_coupons,applied_add_onsandcredit_notesare "simply" added to the Customer type with the definition they had in the Customersingle_objectsubscriptionswas present in both types but a specific resolved was present in the customer details. I applied thesingle_objectresolver on them as it was the one used in FE app.Related Front-End PR: getlago/lago-front#890
Description
This PR merge the Customer
single_objectinto the Customerobjecttype