Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A::random(): exception if $count exceeds array #6555

Merged
merged 2 commits into from
Jul 22, 2024
Merged

A::random(): exception if $count exceeds array #6555

merged 2 commits into from
Jul 22, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 22, 2024 •
edited by bastianallgeier
Loading

Changelog

Fixes

  • A::random() throws exception instead of error when $count is higher than array length

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jul 22, 2024
@distantnative distantnative added this to the 4.4.0 milestone Jul 22, 2024
@distantnative distantnative self-assigned this Jul 22, 2024
@distantnative distantnative linked an issue Jul 22, 2024 that may be closed by this pull request
A::random (Error when the limit is bigger than the array) #5934
Closed
@distantnative distantnative requested a review from a team July 22, 2024 11:25
@distantnative distantnative marked this pull request as ready for review July 22, 2024 11:25
@distantnative distantnative force-pushed the fix/5934-a-random-count-exception branch from 674b25e to 115a6dc Compare July 22, 2024 11:37
bastianallgeier
bastianallgeier reviewed Jul 22, 2024
View reviewed changes
src/Toolkit/A.php Outdated Show resolved Hide resolved
@bastianallgeier bastianallgeier merged commit 8e38cce into develop-minor Jul 22, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/5934-a-random-count-exception branch July 22, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

A::random (Error when the limit is bigger than the array)
2 participants
@distantnative @bastianallgeier