A::random (Error when the limit is bigger than the array)

[modufolio]

Description

Error:

array_rand(): Argument #2 ($num) must be between 1 and the number of elements in argument #1 ($array)

Source

	public static function random(
		array $array,
		int $count = 1,
		bool $shuffle = false
	): array {
		if ($shuffle === true) {
			return array_slice(self::shuffle($array), 0, $count);
		}

		if ($count === 1) {
			$key = array_rand($array);
			return [$key => $array[$key]];
		}

		return self::get($array, array_rand($array, $count));
	}

fix would be:

	public static function random(
		array $array,
		int $count = 1,
		bool $shuffle = false
	): array {
		if ($shuffle === true) {
			return array_slice(self::shuffle($array), 0, $count);
		}

                $arrayCount = count($array);

                // Return the entire array when count is greater or equal to the array size
                if ($count >= $arrayCount) {
                    return $array; 
                }

		if ($count === 1) {
			$key = array_rand($array);
			return [$key => $array[$key]];
		}

		return self::get($array, array_rand($array, $count));
	}

Your setup

kirby cms 4.beta1

[distantnative]

Not sure I agree with the solution. $count is the number of elements you expect to be returned. I think an error message when requesting too many items is more helpful than magically getting fewer item than requested.

[modufolio]

If you say that the error message is more helpful. I suggest to make it visible that the function can throw an error and add a more user friendly message.

Example in Laravel:

if ($requested > $count) {
            throw new InvalidArgumentException(
                "You requested {$requested} items, but there are only {$count} items available."
            );
        }