Add support for image sprites #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: IconSymbolizer.image can be a Sprite
|
Is this really a breaking change? It only adds functionality and does not add/break old functionality (as far as I see). |
simonseyock
reviewed
Oct 19, 2023
simonseyock
approved these changes
Oct 19, 2023
It will break old functionality if you make use of a Sprite. Parsers and UI wont be able to handle this and potential crash or throw errors. |
jansule
approved these changes
Nov 29, 2023
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for sprites to the IconSymbolizer.
It will enhance parsing mapbox styles as they fully rely on sprites: https://docs.mapbox.com/style-spec/reference/sprite/#sprite-files
IMHO it is a breaking change as the UI and other parsers will fail handling a style with a
Sprite.BREAKING CHANGE:
IconSymbolizer.image can be a Sprite
Related to geostyler/geostyler-mapbox-parser#290