Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoStyler should support spritesheets #290

Closed
simonseyock opened this issue Oct 19, 2023 · 1 comment · Fixed by geostyler/geostyler-style#583
Closed

GeoStyler should support spritesheets #290

simonseyock opened this issue Oct 19, 2023 · 1 comment · Fixed by geostyler/geostyler-style#583
Assignees

Comments

@simonseyock
Copy link

Feature Request

mapbox is based on sprite sheets. The sprite property is referreing to an url that points to a .png and .json file, by standard the mentioned mapbox sprite api is not used.

https://docs.mapbox.com/style-spec/reference/root/#sprite

Either mapbox parser can create a base64 image or the other parsers needs to accept spritesheets and handle them.

First option: geostyler-mapbox-parser could get a feature flag if it should request and transform the spritesheets.

Second option: add sprite data information to geostyler style (spriteimage, position, size). OpenLayers supports sprites: properties offset, size in https://openlayers.org/en/latest/apidoc/module-ol_style_Icon-Icon.html

@KaiVolland
Copy link
Contributor

KaiVolland commented Nov 28, 2023

Some things we need to do when realizing sprite support:

  • extend IconLibrary with sprite support
  • adapt parsers (add to unsupportedProperties)
  • think about a solution to split a sprite into single images or a single image (existing library?)
  • speciality of mapbox parser: readd the json and get the real sprite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants