Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make email in contact block "mailto" #523

Merged
merged 4 commits into from
Jul 20, 2023
Merged

feat: Make email in contact block "mailto" #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
598f6b2
feat: Make email mailto
Angi-Kinas Jul 12, 2023
4a327bf
fix(test): Change email to mailto:
Angi-Kinas Jul 13, 2023
fc2e50f
fix: opening in new tab
f-necas Jul 19, 2023
67e8c63
fix: format problem
f-necas Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions libs/ui/elements/src/lib/metadata-contact/metadata-contact.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,17 @@
{{ shownContact.organisation }}
</div>
</div>
<p class="text-gray-700 text-sm">{{ shownContact.email }}</p>
<a
[href]="'mailto:' + shownContact.email"
class="text-gray-700 text-sm"
target="_blank"
>{{ shownContact.email }}</a
>
<div *ngIf="shownContact.website" class="mb-2">
<a
[href]="shownContact.website"
target="_blank"
class="text-primary text-sm cursor-pointer hover:underline transition-all"
class="contact-website text-primary text-sm cursor-pointer hover:underline transition-all"
>{{ shownContact.website }}
<mat-icon class="!w-[12px] !h-[12px] !text-[12px] opacity-75"
>open_in_new</mat-icon
Expand Down
8 changes: 4 additions & 4 deletions libs/ui/elements/src/lib/metadata-contact/metadata-contact.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ describe('MetadataContactComponent', () => {
})
})
describe('content', () => {
let ps
let email
beforeEach(() => {
ps = fixture.debugElement.queryAll(By.css('p'))
email = fixture.debugElement.query(By.css('a'))
})
it('displays the contact name', () => {
const el = fixture.debugElement.query(
Expand All @@ -69,10 +69,10 @@ describe('MetadataContactComponent', () => {
expect(el.innerHTML).toBe(' Worldcorp ')
})
it('displays the contact email', () => {
expect(ps[1].nativeElement.innerHTML).toBe('[email protected]')
expect(email.attributes.href).toBe('mailto:[email protected]')
})
it('displays a link to the contact website', () => {
const a = fixture.debugElement.query(By.css('a'))
const a = fixture.debugElement.query(By.css('.contact-website'))
expect(a.attributes.href).toBe('https://john.world.co')
expect(a.attributes.target).toBe('_blank')
})
Expand Down