-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make email in contact block "mailto" #523
Conversation
Affected libs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Angi-Kinas ! Works as expected.
Don't hesitate to add a short description to your PRs. Not sure what has been decided for the ticket. The implementation doesn't exactly correspond to the ticket's description and conversation. Maybe adding a <gn-ui-copy-text-button>
with the email value on the right to the mailto link would satisfy all demands!?
@@ -10,12 +10,14 @@ | |||
{{ shownContact.organisation }} | |||
</div> | |||
</div> | |||
<p class="text-gray-700 text-sm">{{ shownContact.email }}</p> | |||
<a [href]="'mailto:' + shownContact.email" class="text-gray-700 text-sm">{{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should open the mail in another tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added target _blank attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing
In order to make the email in the contact block clickable, this PR adds the mailto: functionality. As discussed in our weekly, we don't want to add a copy button next to the email, because this is not consistent with what we see on other websites.