Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make email in contact block "mailto" #523

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

@Angi-Kinas Angi-Kinas commented Jul 12, 2023

In order to make the email in the contact block clickable, this PR adds the mailto: functionality. As discussed in our weekly, we don't want to add a copy button next to the email, because this is not consistent with what we see on other websites.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@fgravin fgravin requested a review from tkohr July 13, 2023 12:07
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Angi-Kinas ! Works as expected.

Don't hesitate to add a short description to your PRs. Not sure what has been decided for the ticket. The implementation doesn't exactly correspond to the ticket's description and conversation. Maybe adding a <gn-ui-copy-text-button> with the email value on the right to the mailto link would satisfy all demands!?

@@ -10,12 +10,14 @@
{{ shownContact.organisation }}
</div>
</div>
<p class="text-gray-700 text-sm">{{ shownContact.email }}</p>
<a [href]="'mailto:' + shownContact.email" class="text-gray-700 text-sm">{{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should open the mail in another tab.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added target _blank attribute.

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@fgravin fgravin merged commit f24bd23 into main Jul 20, 2023
8 checks passed
@fgravin fgravin deleted the rework-email-contact-block-record-view branch July 20, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants