Pass created, modified, issued date from thesaurus to the schemas

[wangf1122]

This is to fix the issue metadata101/iso19139.ca.HNAP#308

The issue is the schema transformation style sheet doesn't know if the date is from the thesaurus itself or from the file system last modified date. Therefore, it cannot adjust logic to render different XML template.

[ianwallen]

@wangf1122

I don't believe this is the fix that we are looking for....

@josegar74 @fxprunayre

I think the real bug in this case is that it should never set the last modified date to the system date or the file date.

In our case, we are regularly doing deployments in an K8S environment, and we always copy the thesaurus files during the deployment - this does not mean that the last modified date for the thesaurus was changed.
With this logic, the thesaurus dates on our application are changing almost every time a user does an update.

I believe it should instead just leave it last modified date empty and not modify the values that already exists in the metadata files. If someone really wants a last modified date set then the date should be managed in the thesaurus file.

What are your thoughts?

[josegar74]

@ianwallen the "problem" is that https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19139/src/main/plugin/iso19139/convert/thesaurus-transformation.xsl creates all the thesaurus block from scratch, probably as only receives the parameters of the keyword(s) to add and not the full metadata record.

For me the solution would be to store the creation/publish dates in the vocabulary file, which is possible. The current code server-side code retrieves the modification date (if it exists).

core-geonetwork/core/src/main/java/org/fao/geonet/kernel/Thesaurus.java

Lines 968 to 980 in d7a4b80

	Element dateEl = Xml.selectElement(thesaurusEl, "skos:ConceptScheme/dcterms:issued|skos:Collection/dc:date", theNSs);
	Date thesaususDate = parseThesaurusDate(dateEl);
	if (thesaususDate == null) {
	dateEl = Xml.selectElement(thesaurusEl, "skos:ConceptScheme/dcterms:modified", theNSs);
	thesaususDate = parseThesaurusDate(dateEl);
	}
	if (thesaususDate != null) {
	DateFormat df = new SimpleDateFormat("yyyy-MM-dd");
	this.date = df.format(thesaususDate);
	}

I think it can also be updated to handle the creation date.

[wangf1122]

@ianwallen the "problem" is that https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19139/src/main/plugin/iso19139/convert/thesaurus-transformation.xsl creates all the thesaurus block from scratch, probably as only receives the parameters of the keyword(s) to add and not the full metadata record.

For me the solution would be to store the creation/publish dates in the vocabulary file, which is possible. The current code server-side code retrieves the modification date (if it exists).

core-geonetwork/core/src/main/java/org/fao/geonet/kernel/Thesaurus.java

Lines 968 to 980 in d7a4b80

	Element dateEl = Xml.selectElement(thesaurusEl, "skos:ConceptScheme/dcterms:issued|skos:Collection/dc:date", theNSs);
	Date thesaususDate = parseThesaurusDate(dateEl);
	if (thesaususDate == null) {
	dateEl = Xml.selectElement(thesaurusEl, "skos:ConceptScheme/dcterms:modified", theNSs);
	thesaususDate = parseThesaurusDate(dateEl);
	}
	if (thesaususDate != null) {
	DateFormat df = new SimpleDateFormat("yyyy-MM-dd");
	this.date = df.format(thesaususDate);
	}

I think it can also be updated to handle the creation date.

The issue is this single default date is too general. At schema level (i.e. HNAP 19139) it's hard to tell what to do with it.

I have modified this pull request to pass all possible dates (created, modified, issued) to the schema level. And will let schema decides what to do with the dates. The original date logic is still there which I see it first uses issued date, then go modified. If none is found, then it will use the file system date.

I will make some PR at HNAP metadata to handle this logic. So this change will also give all schemas more flexibilities to deal with these dates.

[josegar74]

I've tested and looks fine. Nice improvement.

@wangf1122 I've updated the PR with xslt changes also: https://github.com/GeoCat/core-geonetwork/tree/main.thesaurus.last.modify.date.flag-xsl-updates

But can't make a pull request to your repository, probably you'll need to give some permissions, otherwise include this commit changes also: GeoCat@4020bfa

[wangf1122]

@josegar74

I have cherry picked your commit into this pull request. All good. Thanks.