Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dates from the thesaurus file if exists instead of file system last modified date from thesaurusDate #327

Merged

Conversation

wangf1122
Copy link
Contributor

This is to fix the issue #308

Also depends on this PR geonetwork/core-geonetwork#6972

Once Geonetwork passed isFilesystemDate flag into the HNAP schema. HNAP will be able to parse it or discard it.

@wangf1122 wangf1122 marked this pull request as ready for review April 5, 2023 15:46
@ianwallen
Copy link
Contributor

Related to #329

@josegar74
Copy link
Contributor

Probably relevant to update https://github.com/metadata101/iso19139.ca.HNAP/blob/3.12.x/src/main/config/codelist/local/thesauri/theme/GC_Core_Subject.rdf as part of this pull request with the relevant dates.

@wangf1122
Copy link
Contributor Author

Yes, the thesaurus file itself needs to be updated. I was thinking to do in a separate PR or if you prefer, I can do into this PR. I am also trying to define what date to put into this file.

@ianwallen
Copy link
Contributor

@josegar74

Probably relevant to update https://github.com/metadata101/iso19139.ca.HNAP/blob/3.12.x/src/main/config/codelist/local/thesauri/theme/GC_Core_Subject.rdf as part of this pull request with the relevant dates.

This is related to the following issue
Related to #329

Once the correct date is identified then we can create a new PR to apply the changes.

Copy link
Contributor

@ianwallen ianwallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the <gmd:date> was created by a function so that it would remove a lot of duplicated code however overall - I have tested and it works as expected.

@ianwallen ianwallen requested a review from josegar74 April 21, 2023 14:53
@ianwallen
Copy link
Contributor

ianwallen commented Apr 21, 2023

If we don't want to wait for related issue #329 , then we can do as @josegar74 suggested and just use the existing values. And when issue #329 identifies the correct dates then we can create another PR to apply the correct dates.

      <dcterms:issued>2004</dcterms:issued>
      <dcterms:created>2016-07-04</dcterms:created>

@wangf1122
Copy link
Contributor Author

wangf1122 commented Apr 21, 2023

I added the default date to the GC_Core thesaurus file. Also group the logics to a single function. Tested and works fine. @ianwallen

@ianwallen ianwallen changed the title Exclude file system last modified date from thesaurusDate Use dates from the thesaurus file if exists instead of file system last modified date from thesaurusDate Apr 25, 2023
@ianwallen ianwallen added this to the 3.12.10 milestone Apr 27, 2023
@ianwallen ianwallen merged commit 5b3c3f4 into metadata101:3.12.x Apr 28, 2023
josegar74 pushed a commit that referenced this pull request Jun 16, 2023
…st modified date from thesaurusDate (#327)

* Exclude file system last modified date from thesaurusDate

* thesaurusDate

* default HNAP template date to GC_Core_Subject.rdf

* default HNAP template date to GC_Core_Subject.rdf .

* group duplicate date parsing logic to single function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants