Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for an Android Studio branch; a trial migration to Android Studio project, Gradle. #279

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

liquiddandruff
Copy link
Contributor

The Eclipse project has been successfully converted by Android Studio and I have made some modifications to the gradle build files so that Android Studio can now be used to build FBReader.

The project builds and FBReader runs perfectly in the simulator/nexus 5 after manual compilation of NDK sources (eg: >ndk-build -C %userprofile%\AndroidStudioProjects\FBReaderJ\fBReaderJ\src\main\jni). This branch can then be used by devs who would like to contribute to FBReader without using Eclipse (which, for all intents and purposes, is now deprecated).

In fact, with a bit of cleanup, the project could probably be moved completely to use Android Studio from now on instead of Eclipse. At the very least, this branch would allow new devs to be able to work on fixing bugs/contributing to features using Android Studio and then commiting their changes to both master and android_studio branches.

Does this sound good?

Studio project using Android Studio.

Compiles and runs after manual compilation of NDK sources.
@liquiddandruff
Copy link
Contributor Author

Can't request to pull into new branches, so I left it at master.

@liquiddandruff liquiddandruff changed the title Converted to Android Studio project Proposal for an Android Studio branch; a trial migration to Android Studio project, Gradle. Jan 7, 2015
@geometer
Copy link
Owner

Good idea, I will try to merge it as soon as I will have some free time. Sorry for delays.

@Xliff
Copy link

Xliff commented May 19, 2017

Was this ever merged properly? Are there recent instructions on how to compile this project in Android Studio. So far I am using this project:

https://github.com/jaychou2012/FBReaderJ-Android-Studio

However it doesn't look to be in sync with this repository.

Thanks

@liquiddandruff
Copy link
Contributor Author

Upstream has diverged too far for my script to work anymore, but people said they had luck with http://www.goldyliang.net/blog/how-to-build-fbreaderj-android/ . Hope you can build it successfully!

@Xliff
Copy link

Xliff commented May 23, 2017

Thanks for the blog reference. I was finally able to use it to compile and generate an APK for the sources. However, this doesn't address the issue of getting it working with Android Studio, where I would prefer to do development.

I guess the only thing left to do would be to try to manually port the sources into the IDE, without diverging too much from the layout of the current sources. I will have to play around with this, but AS doesn't make modifying projects very easy, as I see you have already discovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants