Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw by chance that we still have a number of places in the code where we do
std::pow(x,2)
. This is pretty slow (similar to the cost of allocating astd::vector
), and although most of the occurrences are not performance critical, at least a few are.This PR is a bit of regular expression substitutions magic and a bit of manual substitutions. I think I replaced all cases of
std::pow
with:Utilities::fixed_power
if the exponent is integer and known at compile timeUtilities::pow
if the exponent is integer and known at run time