Qualify std functions everywhere #6072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
force-pushed
the
qualify_sqrt
branch
from
85b8a4f
to
c002d80
Compare
tjhei
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #6069, but for all the other simple functions of the
stdnamespace I could think of. While doing this I also noticed I will have to repeat #6055, because I did not replace all the cases ofpowwithout proper reference tostd. But this PR should strictly only addstd::to a lot of places.Just for future reference, a good regex to find cases without proper namespace:
([^:,^\\])acos( *\()And a regex to replace:
$1std::acos(. Careful when search forsin,cos,tan, sincestd::asin, ...are a valid strings.