Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bioentity view to change label to co-annotation #521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cmungall
Copy link
Member

Fixes #443

@kltm
Copy link
Member

kltm commented Jul 30, 2018

I'm unsure that this is a fix for the given ticket given Val's response. As well, is a single filter selection still "co-annotation"?

@kltm
Copy link
Member

kltm commented Jul 30, 2018

Happy to take either way, just clarifying.

@cmungall
Copy link
Member Author

You're right, it's only co-annotation if a term is already selected

@cmungall
Copy link
Member Author

I think this points to having more specialized pages. We don't have a term page that lists genes, the term page lists annotations by default. You can then hop to getting all genes for that term but this links to query results rather than a page.

@kltm
Copy link
Member

kltm commented Jul 30, 2018

Or pages that display wither gp or anns depending as default, but have both. (Note that earlier versions of A2 had this, but it was deemed confusing; that time may have passed.)

@ValWood
Copy link

ValWood commented Jul 31, 2018

Or pages that display wither gp or anns depending as default, but have both. (Note that earlier versions of A2 had this, but it was deemed confusing; that time may have passed.)

I think I would prefer this. I reckon many people are oblivious to whether they are looking at gene products or annotations. It should be clearer. I often get the wrong one (I usually want annotations). I have already set all my filter and I only know that I'm in the wrong place because I know the numbers I am expecting. Then I switch to gene products, and I lose all of my filters. Annoying. It should be more explicit.

@kltm
Copy link
Member

kltm commented Jul 31, 2018

@ValWood While this is a weird place to discuss it, I think we could actually make the filters portable pretty easily--it's just a transfer via bookmark. I can make a ticket for that (and poke it for a few minutes) if you think it might help out.

@ValWood
Copy link

ValWood commented Jul 31, 2018

Portable filters would be great. I know that is bugging a few of us! @pgaudet

But despite this, I still think it is often not obvious if you are looking at gene products or annotations, and this will be 100x more so for a naive user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants