Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor air pressure demo #632

Draft
wants to merge 11 commits into
base: ros2
Choose a base branch
from
Draft

Refactor air pressure demo #632

wants to merge 11 commits into from
+26 −64

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Nov 4, 2024 •
edited
Loading

Refactors the air_pressure demo leveraging the latest improvements in ros_gz. If we're happy with it, I'll propagate the refactor to all the demos.

  • I replaced the previous launch file from Python to XML because I think it's the recommendation (and looks easier) but I'll still keep some of the demos in Python to offer some variety.
  • I added the QoS support as well. I noticed that because of the QoS, rqt_topic isn't able to show any data. This was probably happening before. Does anybody know if we can pass QoS settings to rqt_topic?

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero
Refactor air pressure demo
88b9cb8 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Update README
63d3a13 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from ahcorde as a code owner November 4, 2024 17:55
@caguero
Tweak
75a6eae 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Run the GUI
1035a72 
Signed-off-by: Carlos Agüero <[email protected]>
ahcorde
ahcorde requested changes Nov 5, 2024
View reviewed changes
ros_gz_sim_demos/launch/air_pressure.launch Outdated
@@ -0,0 +1,6 @@
<launch>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .xml extension

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 643a69b.

ros_gz_sim_demos/README.md Outdated
@@ -14,17 +14,12 @@ There's a convenient launch file, try for example:

Publishes fluid pressure readings.

ros2 launch ros_gz_sim_demos air_pressure.launch.py
ros2 launch ros_gz_sim_demos air_pressure.launch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ros2 launch ros_gz_sim_demos air_pressure.launch
ros2 launch ros_gz_sim_demos air_pressure.launch.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 643a69b.

@caguero
Add xml extension
643a69b 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero marked this pull request as draft November 6, 2024 17:11
@caguero caguero changed the title Air pressure demo refactor Refactor air pressure demo Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caguero @ahcorde