Fix log playback GUI display #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the logging playback plugin before `SceneBroadcaster` prevents playback from being displayed on the GUI. Signed-off-by: Addisu Z. Taddese <[email protected]>
arjo129
reviewed
Sep 10, 2024
|
When will it be merged so that we can finish some tutorials ? |
|
Regression test added in #2619 |
arjo129
approved these changes
Sep 12, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
The CI failure seems to be flaky and is also present in the target branch https://build.osrfoundation.org/view/gz-ionic/job/gz_sim-ci-gz-sim9-noble-amd64/test_results_analyzer/ |
arjo129
added a commit
that referenced
this pull request
Sep 12, 2024
* Adds a regression test for logplayback gazebosim/gazebo_test_cases#1640 This commit adds a really simple regression check to make sure we actually publish on the right topic. Signed-off-by: Arjo Chakravarty <[email protected]> * typo fix Signed-off-by: Arjo Chakravarty <[email protected]> * Make atomic Signed-off-by: Arjo Chakravarty <[email protected]> --------- Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gazebo_test_cases#1640
Alternative to: #2590
Summary
Loading the logging playback plugin before
SceneBroadcasterprevents playback from being displayed on the GUI. This order was changed in #2452 which caused the regression.I haven't had time to delve into why the order matters, but it can easily be verified by running
test/worlds/log_playback.sdfwith<playback_path>set to the log directory. If the plugin comes beforeSceneBroadcaster, the playback is not displayed on the GUI.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.