Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet-featherstone: Fix joint frame data pose #650

Open
wants to merge 1 commit into
base: bullet_kinematic_feature
Choose a base branch
from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 5, 2024

🦟 Bug fix

Related issue #648

Summary

Fix joint frame data pose calculation. Re-enabled a check in JointFrameSemantics test for bullet-featherstone and the test should now pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (bullet_kinematic_feature@081c672). Learn more about missing BASE report.

Files Patch % Lines
bullet-featherstone/src/KinematicsFeatures.cc 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             bullet_kinematic_feature     #650   +/-   ##
===========================================================
  Coverage                            ?   79.30%           
===========================================================
  Files                               ?      140           
  Lines                               ?     8262           
  Branches                            ?        0           
===========================================================
  Hits                                ?     6552           
  Misses                              ?     1710           
  Partials                            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 added Bullet Bullet engine 🎵 harmonic Gazebo Harmonic labels Jun 6, 2024
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey azeey removed the beta Targeting beta release of upcoming collection label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🎵 harmonic Gazebo Harmonic
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants