-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(babel-preset-gatsby): Add corejs to config #12781
fix(babel-preset-gatsby): Add corejs to config #12781
Conversation
Hmmm. This is a bummer. Several failed builds about putting
|
From my read of https://babeljs.io/blog/2019/03/19/7.4.0#migration-from-core-js-2 — we need to use core-js@3 not 2 because we're using |
Thanks @KyleAMathews - I tried to do it the fast way with a find/replace on package.jsons and although tests passed it's not running in my test app. The link you mentioned above actually says that How would you feel about merging to appease babel for now and making followup issues to upgrade |
Ok, the blog post is a bit confusing then. Yeah, then going with 2 for now makes sense and we can upgrade when we release Gatsby v3. |
Holy buckets, @erikdstock — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Gatsby started warning in development mode about a missing but assumed corejs config that was subject to change. The issue linked below tracks down the source of the problem and this fix quiets it down. Thanks!
Related Issues
Fixes #12744