This repository has been archived by the owner on Nov 3, 2019. It is now read-only.
fix babel warnings, add required babel dependencies #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardodino
commented
Mar 27, 2019
packages/gatsby-mdx/utils/gen-mdx.js
Outdated
| @@ -146,7 +147,10 @@ module.exports = async function genMDX({ | |||
| results.scopeIdentifiers = identifiers; | |||
| // TODO: be more sophisticated about these replacements | |||
| results.body = result.code | |||
| .replace(/export\s*{\s*MDXContent\s+as\s+default\s*};?/, "return MDXContent;") | |||
There was a problem hiding this comment.
I can amend it, if wanted. but was auto-formatted anyways. 🤷♂️
|
I wonder if we should use babel-preset-gatsby here instead 🤔 |
|
Thanks for the PR @leonardodino It'll take a second to merge since we've stopped development on babel-preset-gatsby might be the right move here. The loader passes through to the user's babel-loader config in the loader chain while the "generated" code path only has this code path to return usable code. |
ChristopherBiscardi
force-pushed
the
master
branch
from
e8c9417 to
78b5893
Compare
|
merged in 78b5893 Thanks @leonardodino ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading gatsby resulted in this module throwing a huge amount of babel warnings.
(probably one for each file)
this fixes that (:
gen-mdxingatsby-mdx/package.jsonpre-commithook reformated a line contaning a regexprelated issue in gatsby core
related PR in gatsby core