Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure action fails when used so users are pointed to updated docs #100

Merged
merged 5 commits into from
Dec 24, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
{
"plugins": ["jest", "@typescript-eslint", "prettier", "unicorn"],
"extends": ["plugin:unicorn/recommended", "plugin:github/recommended", "prettier"],
"extends": [
"plugin:unicorn/recommended",
"plugin:github/recommended",
"plugin:prettier/recommended"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 9,
"sourceType": "module"
"ecmaVersion": 2020,
"sourceType": "module",
"extraFileExtensions": [".mjs"],
"ecmaFeatures": {
"impliedStrict": true
},
"project": "./tsconfig.json"
},
"env": {
"node": true,
Expand All @@ -17,6 +26,7 @@
"import/no-namespace": "off",
"filenames/match-regex": "off",
"unicorn/prefer-node-protocol": "off",
"unicorn/prefer-module": "off"
"unicorn/prefer-module": "off",
"i18n-text/no-en": "off"
}
}
36 changes: 13 additions & 23 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
name: Actions 😎
on:
pull_request: {}
push: { branches: [main] }
pull_request:
push:

jobs:
tests:
name: Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 12.x
node-version: 20.x
- run: yarn
- run: yarn lint
- run: yarn test
Expand All @@ -21,30 +21,20 @@ jobs:
requestManualActivationFile:
name: Request manual activation file 🔑
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
unityVersion:
- 2018.4.15f1
- 2019.2.11f1
- 2019.2.14f1
- 2019.2.17f1
# - 2020.1.0a15
steps:
# Checkout repository (required to test local actions)
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4

# Request manual activation file
- name: Request manual activation file
id: getManualLicenseFile
continue-on-error: true
uses: ./
with:
unityVersion: ${{ matrix.unityVersion }}

# Upload artifact (Unity_v20XX.X.XXXX.alf)
- name: Expose as artifact
uses: actions/upload-artifact@v2
with:
name: ${{ steps.getManualLicenseFile.outputs.filePath }}
path: ${{ steps.getManualLicenseFile.outputs.filePath }}
- name: Verify error
AndrewKahr marked this conversation as resolved.
Show resolved Hide resolved
run: |
if [ "${{ steps.getManualLicenseFile.outcome }}" != "failure" ]; then
echo "Expected failure, got ${{ steps.getManualLicenseFile.outcome }}"
exit 1
fi
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

(Not affiliated with Unity Technologies)

**This action is no longer maintained and should not be used. Please follow the [updated activation steps](https://game.ci/docs/github/activation) for v4 and newer of Unity Actions.**

GitHub Action for
[requesting the manual activation file](https://github.com/marketplace/actions/unity-request-activation-file) for Unity.

Expand Down
16 changes: 2 additions & 14 deletions action.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,9 @@
name: 'Unity - Request Activation File'
author: Webber Takken <[email protected]>
description: 'Request the manual activation file for acquiring a Unity personal license.'
inputs:
unityVersion:
required: false
default: '2019.2.11f1'
description: 'Version of unity to use for building the project.'
customImage:
required: false
default: ''
description: 'Specific docker image that should be used to request activation file'
outputs:
filePath:
description: 'Path of the manual activation file'
description: '[DEPRECATED] Request the manual activation file for acquiring a Unity personal license.'
branding:
icon: 'box'
color: 'gray-dark'
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
15 changes: 0 additions & 15 deletions dist/Dockerfile

This file was deleted.

58 changes: 0 additions & 58 deletions dist/entrypoint.sh

This file was deleted.

Loading
Loading