Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure action fails when used so users are pointed to updated docs #100

Merged
merged 5 commits into from
Dec 24, 2023

Conversation

AndrewKahr
Copy link
Member

Changes

  • Ensure action prints an error and informs the end user about updated activation instructions

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@GabLeRoux
Copy link
Member

GabLeRoux commented Dec 24, 2023

I tested this and it worked as expected 👍

CleanShot 2023-12-24 at 09 52 17@2x

Documentation at v3 suggested a workflow like this:

name: Acquire activation file
on:
  workflow_dispatch: {}
jobs:
  activation:
    name: Request manual activation file 🔑
    runs-on: ubuntu-latest
    steps:
      # Request manual activation file
      - name: Request manual activation file
        id: getManualLicenseFile
        uses: game-ci/unity-request-activation-file@v2
      # Upload artifact (Unity_v20XX.X.XXXX.alf)
      - name: Expose as artifact
        uses: actions/upload-artifact@v2
        with:
          name: ${{ steps.getManualLicenseFile.outputs.filePath }}
          path: ${{ steps.getManualLicenseFile.outputs.filePath }}

Once merged, using the above and executing the manual action will produce output like in above screenshot.

:shipit:

.github/workflows/main.yml Outdated Show resolved Hide resolved
Co-authored-by: Webber Takken <[email protected]>
@AndrewKahr AndrewKahr merged commit 65874ef into main Dec 24, 2023
4 checks passed
@AndrewKahr AndrewKahr deleted the update-for-v4 branch December 24, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants