Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sfold #6504
base: main
Are you sure you want to change the base?
Add Sfold #6504
Changes from 13 commits
6831058
70d1a47
e264d9f
dce5af7
2b2737c
d7103a5
c1d4279
e9a140a
8d6b91b
50983d3
e153e9f
7e8d59d
3dcb1c9
cf119ea
e5a6ad3
a95bb0f
caf691b
f7bbe93
d68ad6a
09da460
83e3955
abb123b
0a4212b
cb346c1
18e6513
5fecdbf
7c2aa74
a4ce5fa
14f7494
17f433a
4067019
5cbb42c
cc4fc70
0ce1f16
1fb56ce
9657a84
991420c
d447658
c64ab77
b0e91ce
218c745
c41fa37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section can be removed I think, there is only one option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. Why only one option?
Sfold can use two modules, "Soligo", "Sirna", or both. It can also use none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its only one select parameter. I'm not sure its worthwhile to hide one parameter under a section. Imho it make sense to hide many parameters in a section. Its just an opinion you can also keep it like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment. The sfold.xml file was updated based on that.