-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sfold #6504
base: main
Are you sure you want to change the base?
Add Sfold #6504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a .shed.yml to trigger the tests.
The sfold.xml file was edited and completed. I also added a .shed.yml file. |
|
The file is in the container:
Shebang looks also good:
|
The Planemo test was passed. |
tools/sfold/sfold.xml
Outdated
<option value="2">Soligo</option> | ||
<option value="3">Both</option> | ||
</param> | ||
<section name="output" title="Output Options"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section can be removed I think, there is only one option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. Why only one option?
Sfold can use two modules, "Soligo", "Sirna", or both. It can also use none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its only one select parameter. I'm not sure its worthwhile to hide one parameter under a section. Imho it make sense to hide many parameters in a section. Its just an opinion you can also keep it like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment. The sfold.xml file was updated based on that.
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
The sfold.xml file was edited to fix the error related to test 2. |
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO select
with multiple="true"
without checkbox
does not have a good UI/UX.
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
looks good to me. Thanks @reytakop |
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Co-authored-by: Amirhossein <[email protected]>
Congratulations on your first contribution to the Galaxy Reyhaneh! 🎉 |
FOR CONTRIBUTOR: