Fix lint job stopping early after first failure #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
fix-lint
branch
from
7cada98 to
98dd75a
Compare
bernt-matthias
force-pushed
the
fix-lint
branch
from
98dd75a to
fcc0286
Compare
since we use pipefail the previous did not work
bernt-matthias
changed the title
nsoranzo
reviewed
Dec 15, 2023
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
planemo lintbreaks the loop after the first tool that fails linting. Hard to spot because most jobs contain a single tool and in the past we usedfail_levelerrorwhich happened seldomly for multiple tools.