Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of .shed.yml file for a tool or set of tools results in action deciding to do nothing but not giving an error #53

Open
pcm32 opened this issue Sep 12, 2023 · 3 comments

Comments

@pcm32
Copy link
Member

pcm32 commented Sep 12, 2023

Thanks again for this great action, we use it constantly.

I've noticed that if the .shed.yml file is not present in the directory of modified tools, the action doesn't fail but following steps don't take care of the tools. Maybe this is an issue on our CI setup, but I wonder if it would be better if part that determines commit ranges, repos and chunks fails instead alerting the user of the lack of a .shed.yml file? I took me a bit of time to realise it was missing.

@nsoranzo
Copy link
Member

The .shed.yml file is used to identify directories that should contain tools/workflows from directories to ignore, so I don't see how we can support this unfortunately.

@pcm32
Copy link
Member Author

pcm32 commented Sep 14, 2023

No, of course, you cannot support it, I meant it should fail more explicitly rather than not doing anything in the following steps. From the outside, it looks like everything is successful + skipped = succes, which is misleading.

@bernt-matthias
Copy link
Collaborator

Actually we have such a check

echo "Tool $TOOL not in changed repositories list: .shed.yml file missing" >&2

I would hope that this fixes it? #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants