Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate tagging into the rule builder. #6500

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Jul 13, 2018

  • Allow specifying name tags, group tags (added in Implement group: tags (toward multi-factor analysis with group tagging) #6491), and "general" or generic tags on stand-alone datasets and collection content datasets.
  • Allow reusing the collection name as a name tag during upload for the whole collection. In this context I think the name tag is especially useful and will typically be the same name as the collection so the UI is kept simple by making it a checkbox.

Ideas tracked on #5822.

Builds on #6499.

@jmchilton jmchilton added this to the 18.09 milestone Jul 13, 2018
@jmchilton jmchilton changed the title Integrate tagging into the rule builder. [WIP] Integrate tagging into the rule builder. Jul 13, 2018
@jmchilton jmchilton force-pushed the rule_builder_tags branch from 8939c49 to 5b59f03 Compare July 14, 2018 00:10
Rebased with default argument handling improvements suggested by Marius.
@jmchilton jmchilton force-pushed the rule_builder_tags branch from 5b59f03 to f9ba8d3 Compare July 16, 2018 12:47
- Allow specifying name tags, group tags, and "general" tags on stand-alone datasets and collection content datasets.
- Allow reusing the collection name as a name tag during upload for the whole collection. In this context I think the name tag is especially useful and will typically be the same name as the collection so the UI is kept simple by making it a checkbox.
@jmchilton jmchilton changed the title [WIP] Integrate tagging into the rule builder. Integrate tagging into the rule builder. Jul 16, 2018
@dannon
Copy link
Member

dannon commented Jul 18, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants