Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Only allow moving activity bar icons when editing the bar. #19258

Merged

Conversation

jmchilton
Copy link
Member

Add small visual indicator that they can be moved.

There was a broad consensus at the dev team meeting that this was a good change but the impetus was release testing the new workflow activity bar and being confused by this behavior.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Try to move the activity bar icons without being in the settings, notice they cannot move. Click settings and see they can move now.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Add small visual indicator that they can be moved.
@jmchilton jmchilton added kind/bug release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them area/UI-UX labels Dec 5, 2024
@jmchilton jmchilton marked this pull request as ready for review December 5, 2024 20:38
@github-actions github-actions bot added this to the 25.0 milestone Dec 5, 2024
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great and looks nice too! Thanks!

Screencast

stray_moving_24_2

@ahmedhamidawan ahmedhamidawan merged commit ea0308c into galaxyproject:release_24.2 Dec 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/bug release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants