Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor drag style adjustment for activities #19299

Merged

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Dec 10, 2024

Very minor style follow-up for: #19258. Avoids highlighting hidden activities, such as e.g. Interactive tools and uses theme attributes. Thanks a lot for the elegant implementation @jmchilton.

Before:
image

After:
image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 25.0 milestone Dec 10, 2024
@guerler guerler requested a review from jmchilton December 10, 2024 16:59
@guerler guerler marked this pull request as ready for review December 10, 2024 19:01
@jmchilton
Copy link
Member

Very nice enhancements - thanks @guerler!

@jmchilton jmchilton merged commit a354124 into galaxyproject:dev Dec 10, 2024
33 checks passed
@guerler guerler deleted the minor-drag-style-adjustment-activities branch December 10, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants