Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Raise appropriate exception if ldda not found #18569

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jul 19, 2024

Fixes
https://sentry.galaxyproject.org/share/issue/db137d5e4eae40eea9b0fe85ffac4b19/:

AssertionError: null
  File "galaxy/web/framework/decorators.py", line 346, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/api/tools.py", line 593, in create
    return self.service._create(trans, payload, **kwd)
  File "galaxy/webapps/galaxy/services/tools.py", line 155, in _create
    self._patch_library_inputs(trans, inputs, target_history)
  File "galaxy/webapps/galaxy/services/tools.py", line 276, in _patch_library_inputs
    patched = self._patch_library_dataset(trans, value, target_history)
  File "galaxy/webapps/galaxy/services/tools.py", line 284, in _patch_library_dataset
    assert ldda

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Fixes
https://sentry.galaxyproject.org/share/issue/db137d5e4eae40eea9b0fe85ffac4b19/:

```
AssertionError: null
  File "galaxy/web/framework/decorators.py", line 346, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/api/tools.py", line 593, in create
    return self.service._create(trans, payload, **kwd)
  File "galaxy/webapps/galaxy/services/tools.py", line 155, in _create
    self._patch_library_inputs(trans, inputs, target_history)
  File "galaxy/webapps/galaxy/services/tools.py", line 276, in _patch_library_inputs
    patched = self._patch_library_dataset(trans, value, target_history)
  File "galaxy/webapps/galaxy/services/tools.py", line 284, in _patch_library_dataset
    assert ldda
```
@github-actions github-actions bot added this to the 24.1 milestone Jul 19, 2024
@mvdbeek mvdbeek merged commit 5c43d00 into galaxyproject:release_24.1 Jul 19, 2024
45 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants