Merge pull request #18569 from mvdbeek/ldda_not_found

[24.1] Raise appropriate exception if ldda not found
galaxyproject · Jul 19, 2024 · 5c43d00 · 5c43d00
2 parents cbbb5ef + 46aa4c0
commit 5c43d00
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/galaxy/webapps/galaxy/services/tools.py b/lib/galaxy/webapps/galaxy/services/tools.py
@@ -281,7 +281,8 @@ def _patch_library_inputs(self, trans: ProvidesHistoryContext, inputs, target_hi
     def _patch_library_dataset(self, trans: ProvidesHistoryContext, v, target_history):
         if isinstance(v, dict) and "id" in v and v.get("src") == "ldda":
             ldda = trans.sa_session.get(LibraryDatasetDatasetAssociation, self.decode_id(v["id"]))
-            assert ldda
+            if not ldda:
+                raise exceptions.ObjectNotFound("Could not find library dataset dataset association.")
             if trans.user_is_admin or trans.app.security_agent.can_access_dataset(
                 trans.get_current_user_roles(), ldda.dataset
             ):