-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Declarative Testing for Workflow Behaviors #18542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
workflow_tests
branch
3 times, most recently
from
July 15, 2024 15:29
1b4e592
to
b19d8c6
Compare
jmchilton
force-pushed
the
workflow_tests
branch
3 times, most recently
from
July 26, 2024 14:54
daf961b
to
9b36ac2
Compare
jmchilton
force-pushed
the
workflow_tests
branch
from
July 29, 2024 13:19
9b36ac2
to
ad0ad85
Compare
mvdbeek
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does look cleaner, thank you!
Co-authored-by: Marius van den Beek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_workflows.py
has long grown unwieldy and many tests are just running workflows and checking outputs. I think these should be broken out and done in a declarative manner. I was also pondering #18541 and trying to think about how and where to describe the expected behavior and I didn't think just adding another test to the monster file was the right approach. I think there are limitations to what is being done with framework test tools (added in 569c5db) but they are better than a bunch of Python test cases I believe. In this PR, I have created a framework for running workflow framework tests to match framework tool tests. I've migrated a few workflow tests to the framework and I have implemented my desired test for #18541.The syntax is not exactly what Planemo uses for workflow tests... but it is close and I think we can converge there over time. The biggest change is just input descriptions - the workflow tests grew up around automatically generated fixtures and Planemo is optimized for users specifying actual files. So the input specification is different - but they already different in the string-ified YAML throughout the test framework. I've implemented the
elements
syntax introduced by @mvdbeek for Planemo in galaxyproject/planemo#1417.How to test the changes?
(Select all options that apply)
License