Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace History Dataset Picker in Library Folder #18518

Merged
merged 33 commits into from
Sep 16, 2024
Merged

Replace History Dataset Picker in Library Folder #18518

merged 33 commits into from
Sep 16, 2024

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Jul 9, 2024 •
edited
Loading

This PR is a follow-up on #18488. It introduces a new datasets selector, HistoryDatasetPicker, which is a generic component that utilizes SelectionDialog to allow users to explore their histories and select datasets.
Also, add total_matches header to the "/api/datasets" GET request.

History.Dataset.Picker.in.Library.Folder.mp4

SelectionDialog improvements:

  • Make folder icon, title, and ok button text customizable
  • Use FilterMenu when it's needed
  • Improve types

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Open a library in Data Libraries
    2. Click on Datasets > from History
    3. Select history and datasets to add to the library

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.2 milestone Jul 9, 2024
@itisAliRH itisAliRH mentioned this pull request Jul 9, 2024
Merged
4 tasks
@itisAliRH itisAliRH marked this pull request as draft July 9, 2024 14:36
@itisAliRH itisAliRH force-pushed the libraries-modernization-1-history-dataset-picker branch 3 times, most recently from 796bb43 to 64f8c7c Compare July 26, 2024 16:06
@itisAliRH itisAliRH force-pushed the libraries-modernization-1-history-dataset-picker branch from 33d4717 to 84de504 Compare August 2, 2024 12:39
@itisAliRH itisAliRH mentioned this pull request Aug 2, 2024
Merged
4 tasks
@itisAliRH itisAliRH force-pushed the libraries-modernization-1-history-dataset-picker branch 2 times, most recently from e67ee2f to 0fdbe92 Compare August 2, 2024 13:38
@itisAliRH itisAliRH changed the title Libraries Modernisation: History Dataset Picker Replace History Dataset Picker in Library Folder Aug 2, 2024
itisAliRH and others added 18 commits September 11, 2024 14:41
@itisAliRH
🛠️: refactor SelectionDialog/selectionTypes.ts to use TypeScript li…
ceb40a2 
…teral types for selection states and rename `selectAllIcon` prop to `selectAllVariant` in `SelectionDialog`
@itisAliRH
✨: add FilterMenu, folderIcon and okButtonText and searchTitle …
5101d0f 
…props to `SelectionDialog`
@itisAliRH
✨: create api/folders with postFolderContent endpoint
504ccbb
@itisAliRH
🎉: create HistoryDatasetPicker in Library
ef6c289
@itisAliRH
🎨: use HistoryDatasetPicker in FolderTopBar
57f43c7
@itisAliRH
✨: add and expose resetPagination method to SelectDialog
d6eba5a
@itisAliRH
🐛: fix reactivity issue when selecting an item in HistoryDatasetPicker
a950dd7
@itisAliRH
🐛: fix filter and pagination issues in HistoryDatasetPicker
2684bf7
@itisAliRH
✨: add and expose resetFilter method to SelectDialog
e951cdd
@itisAliRH
🐛: fix filter reset issue in HistoryDatasetPicker
669a695
@itisAliRH
🛠️: update navigation.yml selectors for HistoryDatasetPicker
ae1169c
@itisAliRH
🛠️: add libraries_dataset_import_from_history_search_for in `naviga…
03f50f5 
…tes_galaxy` and update `libraries_dataset_import_from_history_select`
@itisAliRH
🛠️: update test_library_contents to work with HistoryDatasetPicker
9fd716f
@itisAliRH
🎨: add submitting state and success toast to HistoryDatasetPicker
be37798
@itisAliRH
🛠️: update FolderTopBar to use useConfig composable
45205f5
@itisAliRH
🐛: reset filter in HistoryDatasetPicker on onUndo
5aac94b
@itisAliRH @arash77
✨: add total_matches to GET "/api/datasets"
617c3b6 
Co-authored-by: Arash Kadkhodaei <[email protected]>
@itisAliRH
🛠️: update getDatasets to return total_matches and update the usa…
6859769 
…ge accordingly
@itisAliRH itisAliRH force-pushed the libraries-modernization-1-history-dataset-picker branch from 0fdbe92 to 73c1f49 Compare September 11, 2024 13:03
@itisAliRH itisAliRH marked this pull request as ready for review September 11, 2024 17:36
davelopez
davelopez reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor suggestions :)

client/src/components/Libraries/LibraryFolder/TopToolbar/HistoryDatasetPicker.vue Outdated Show resolved Hide resolved
client/src/components/Libraries/LibraryFolder/TopToolbar/HistoryDatasetPicker.vue Outdated Show resolved Hide resolved
client/src/components/SelectionDialog/SelectionDialog.vue Outdated Show resolved Hide resolved
client/src/components/SelectionDialog/selectionTypes.ts Outdated Show resolved Hide resolved
@itisAliRH
Copy link
Member Author

@davelopez thank you for the review! I have pushed the changes we discussed.

@itisAliRH itisAliRH marked this pull request as draft September 13, 2024 12:29
@itisAliRH itisAliRH requested a review from davelopez September 13, 2024 15:39
@itisAliRH itisAliRH marked this pull request as ready for review September 13, 2024 15:39
davelopez
davelopez approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! It looks pretty cool to me!

@davelopez davelopez added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Sep 13, 2024
@itisAliRH
Copy link
Member Author

The failed tests are not relevant.

@davelopez davelopez merged commit fc8dc87 into galaxyproject:dev Sep 16, 2024
54 of 56 checks passed
@itisAliRH itisAliRH deleted the libraries-modernization-1-history-dataset-picker branch September 16, 2024 10:20
@martenson
Copy link
Member

Very nice @itisAliRH !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@itisAliRH @martenson @davelopez