Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix typing issue in reused variable #18344

Merged

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Jun 7, 2024

Follow up to #18329, fixes mypy (and ruff) checks in 24.1
The version of mypy in 24.0 didn't catch this earlier, but nicely, the one in 24.1 does.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes minor area/API labels Jun 7, 2024
@davelopez davelopez mentioned this pull request Jun 7, 2024
4 tasks
@davelopez davelopez merged commit d0f01af into galaxyproject:release_24.1 Jun 7, 2024
50 of 51 checks passed
@davelopez davelopez deleted the 24.1_fix_typing_index_users branch June 7, 2024 11:15
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants