Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff errors #18345

Closed
Closed

Conversation

bernt-matthias
Copy link
Contributor

C405 Unnecessary `list` literal (rewrite as a `set` literal)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

```
C405 Unnecessary `list` literal (rewrite as a `set` literal)
```
@davelopez
Copy link
Contributor

davelopez commented Jun 7, 2024

Thanks @bernt-matthias. It should be fixed in #18344 along with another mypy issue that was not caught by mypy (and ruff) version in 24.0 so it targets 24.1 and will be merged forward to dev at some point 😅

@bernt-matthias bernt-matthias deleted the ruff-fix-405 branch June 7, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants