Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Restrict job_files access to jobs that are not terminal #18217

Merged
merged 1 commit into from
May 24, 2024
Merged

[24.0] Restrict job_files access to jobs that are not terminal #18217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/galaxy/webapps/galaxy/api/job_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def __authorize_job_access(self, trans, encoded_job_id, **kwargs):

# Verify job is active. Don't update the contents of complete jobs.
job = trans.sa_session.get(Job, job_id)
if job.finished:
if job.state not in Job.non_ready_states:
error_message = "Attempting to read or modify the files of a job that has already completed."
raise exceptions.ItemAccessibilityException(error_message)
return job
Expand Down
2 changes: 1 addition & 1 deletion lib/galaxy/webapps/galaxy/api/job_tokens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def __authorize_job_access(self, trans, encoded_job_id, job_key):

# Verify job is active
job = session.get(Job, job_id)
if job.finished:
if job.state not in Job.non_ready_states:
error_message = "Attempting to get oidc token for a job that has already completed."
raise exceptions.ItemAccessibilityException(error_message)
return job
Loading