Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Restrict job_files access to jobs that are not terminal #18217

Merged
merged 1 commit into from
May 24, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 23, 2024

That should fix https://sentry.galaxyproject.org/share/issue/c4eb157823c240d5a664ec6517354db2/

This is just noise and has tripped me up multiple times both on the Galaxy and Pulsar side.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek merged commit 21a4272 into galaxyproject:release_24.0 May 24, 2024
51 checks passed
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants